From 78380c34dfeb27da3d0222bcb7232c5d8e2f5b30 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Wed, 27 Mar 2013 08:46:28 +0100 Subject: [PATCH] x86/EFI: permit setting variable with non-zero attributes This must have been a copy-and-paste mistake - get_variable uses op->misc as output only, and wants to make sure it's zero for future extensibility. For set_variable, this is an input though, and hence the check is wrong. Signed-off-by: Jan Beulich Acked-by: Keir Fraser --- xen/arch/x86/efi/runtime.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/arch/x86/efi/runtime.c b/xen/arch/x86/efi/runtime.c index 73aa15eb9a..aafdfebdd8 100644 --- a/xen/arch/x86/efi/runtime.c +++ b/xen/arch/x86/efi/runtime.c @@ -398,9 +398,6 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op) long len; unsigned char *data; - if ( op->misc ) - return -EINVAL; - len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16)); if ( len < 0 ) return len; -- 2.30.2